Open
Conversation
ghost
approved these changes
Jan 8, 2025
ghost
left a comment
There was a problem hiding this comment.
I'm not a maintainer, but would like to see this merged.
There are similar changes in the WebXR PR (https://github.com/videojs/videojs-vr/pull/273/files#diff-598b75d6dc772eb13aa7141f35bb93046ae26c58a97e8647ecf7f74aec8ae93fR156). Unfortunately, it looks like that PR may be abandoned? I'm planning to open up a PR with our fork, but it will be rather large. Any smaller PRs that make our fork PR smaller would be very helpful.
|
Thanks @KasperQd ; my issue was fixed with your PR ! Best regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the code to use the new Three API. The old code used a deprecated API, which caused none of the projections but '360' to work.
This PR solves issues: #256, #268 and #266
Specific Changes proposed
Requirements Checklist