fix: downgrade fix-path to v4 for CJS compat, lowercase productName#19
Draft
lalit-videodb wants to merge 2 commits intovideo-db:mainfrom
Draft
fix: downgrade fix-path to v4 for CJS compat, lowercase productName#19lalit-videodb wants to merge 2 commits intovideo-db:mainfrom
lalit-videodb wants to merge 2 commits intovideo-db:mainfrom
Conversation
…add install script - fix-path v5 is ESM-only which breaks CJS build (TS2307) - Lowercase productName + CFBundleDisplayName for consistent branding - Add artifactName with arch suffix for DMG naming - Add install script for curl-based installation - Add publish.sh to .gitignore
- Keep fix-path v5 (ESM-only) and use dynamic import() instead of downgrading - Accept upstream version bump (1.0.1) and videodb ^0.2.4 - Resolve package.json and package-lock.json merge conflicts
Collaborator
|
Can you share the exact error you were facing and for which actions? Will help me gauge wether this PR is required or not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import()forfix-pathv5 (ESM-only) so it works in the CJS main process — fixesTS2307: Cannot find module 'fix-path'productNametocall.mdwithCFBundleDisplayName/CFBundleNamefor consistent branding in macOS permission dialogsartifactNamewith${arch}suffix so both x64 and arm64 DMGs get distinct filenamesinstallscript for easy installationpublish.shto.gitignoreTest plan
npm run buildcompletes without TS errorsnpm run dist:macproduces correctly named DMGs with arch suffix