feat: add --https flag for auto-generated self-signed certificates#841
Open
hemanth wants to merge 1 commit intovercel:mainfrom
Open
feat: add --https flag for auto-generated self-signed certificates#841hemanth wants to merge 1 commit intovercel:mainfrom
hemanth wants to merge 1 commit intovercel:mainfrom
Conversation
Author
|
//cc @rauchg @timneutkens @arunoda |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
--httpsflag that auto-generates a self-signed TLS certificate at startup, so you can serve over HTTPS without providing your own certs.Why
Testing service workers, WebAuthn, Secure Contexts, and other HTTPS-only browser APIs locally shouldn't require mkcert or OpenSSL. One flag, zero setup.
How
source/utilities/tls.ts— generates a self-signed X.509 v3 certificate using Node's built-incryptomodule (no new dependencies)localhost,127.0.0.1, and::1(1-year validity, 2048-bit RSA)https.createServer()path inserver.ts--ssl-cert/--ssl-keytakes priority over--httpsFiles changed
source/utilities/tls.tssource/types.ts--httpstoOptionssource/utilities/cli.tssource/utilities/server.tsTesting
serve --https→ serves onhttps://localhost:3000curl -k https://localhost:3000→ HTTP 200serve(without flag) → HTTP unchanged