[3/9] feat: strip basedirs from Rust hash key for cross-machine cache hits#10
Open
mmastrac wants to merge 1 commit intovercel/crate-type-allow-hashfrom
Open
[3/9] feat: strip basedirs from Rust hash key for cross-machine cache hits#10mmastrac wants to merge 1 commit intovercel/crate-type-allow-hashfrom
mmastrac wants to merge 1 commit intovercel/crate-type-allow-hashfrom
Conversation
SCCACHE_BASEDIRS now normalizes cwd, CARGO_MANIFEST_DIR, CARGO_WORKSPACE_DIR, and dep-info env var values in the Rust compiler's hash key computation. This enables cache hits when the same crate is compiled from different absolute paths on different machines (e.g., CI runners with different checkout dirs). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mmastrac
force-pushed
the
vercel/rust-basedirs
branch
from
b8ee6b2 to
3f6f57a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SCCACHE_BASEDIRSsupport to the Rust compiler hash key, matching the existing C compiler behaviorcwd,CARGO_MANIFEST_DIR,CARGO_MANIFEST_PATH,CARGO_WORKSPACE_DIR,CARGO_TARGET_TMPDIR,CARGO_BIN_EXE_*, dep-info env var values, and the concatenated argument string (catches--remap-path-prefix,-Clinker=, etc.)Test plan
test_basedirs_strips_cwd_and_cargo_manifest_dir— verifies basedirs changes the hashtest_basedirs_deterministic— verifies same basedir produces same hashtest_generate_hash_key— existing test updated for new hash formatcargo clippyclean🤖 Generated with Claude Code