Turbopack: Add a check for node version before allowing workerThreads#91614
Open
Turbopack: Add a check for node version before allowing workerThreads#91614
Conversation
nextjs-bot
added
created-by: Turbopack team
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
|
Notifying the following users due to files changed in this PR based on this repo's notify modifiers: @timneutkens, @ijjk, @shuding, @huozhi: |
Collaborator
Failing test suitesCommit: 4954704 | About building and testing Next.js
Expand output● turbopack-node-backend (workerThreads) › should match expected loader pid behavior |
bgw
commented
Mar 18, 2026
| import { basename, extname, join, relative, isAbsolute, resolve } from 'path' | ||
| import { pathToFileURL } from 'url' | ||
| import findUp from 'next/dist/compiled/find-up' | ||
| import semver from 'next/dist/compiled/semver' |
Member
Author
There was a problem hiding this comment.
We already always pull in this dependency in the CLI to check your node.js version and exit the CLI with an error if you're on an unsupported version.
Collaborator
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URL |
|
|
||
| const isBun = !!process.versions.bun | ||
| const isDeno = !!process.versions.deno | ||
| if (!isBun && !isDeno) { |
Contributor
There was a problem hiding this comment.
can we use a positive test instead? isNode?
Member
Author
There was a problem hiding this comment.
You can't check for process.versions.node because bun (and probably deno too, I didn't check) puts fake values there for compatibility reasons.
lukesandberg
approved these changes
Mar 18, 2026
sokra
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to start dogfooding
workerThreads, but we can only safely do it if you have a new enough node version.We don't have any sort of strong enforcement around node.js version in front (e.g. you could have a misconfigured nvm or fnm), so we need to check the node version first.
Looks like this:
Related Node.js version bump for front: https://github.com/vercel/front/pull/65059