CNF-18932: fix(makefile): preserve HTTP protocol in TARGET_REPO URL conversion#628
Closed
leo8a wants to merge 1 commit intovalidatedpatterns:mainfrom
Closed
CNF-18932: fix(makefile): preserve HTTP protocol in TARGET_REPO URL conversion#628leo8a wants to merge 1 commit intovalidatedpatterns:mainfrom
leo8a wants to merge 1 commit intovalidatedpatterns:mainfrom
Conversation
The TARGET_REPO sed logic was incorrectly converting HTTP URLs like "http://host/repo.git" to malformed "https://http///host/repo.git" due to aggressive colon replacement. Updated to only convert SSH URLs (git@) to HTTPS while preserving the original protocol for HTTP/HTTPS URLs. Fixes validate-origin target failures for HTTP-only repositories. Signed-off-by: Leonardo Ochoa lochoa@redhat.com
Author
|
/cc @beekhof @dminnear-rh |
Author
|
If you try to disable the check by Then the Pattern operator fails with below error /cc @dminnear-rh |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TARGET_REPO sed logic was incorrectly converting HTTP URLs like "http://host/repo.git" to malformed "https://http///host/repo.git" due to aggressive colon replacement.
Updated to only convert SSH URLs (git@) to HTTPS while preserving the original protocol for HTTP/HTTPS URLs.
Fixes validate-origin target failures for HTTP-only repositories.
Signed-off-by: Leonardo Ochoa-Aday lochoa@redhat.com