Skip to content

fix: add package.json overrides for workbox dependencies#24008

Open
platosha wants to merge 6 commits intomainfrom
fix/workbox-overrides
Open

fix: add package.json overrides for workbox dependencies#24008
platosha wants to merge 6 commits intomainfrom
fix/workbox-overrides

Conversation

@platosha
Copy link
Contributor

@platosha platosha commented Mar 25, 2026

  • Add PwaConfiguration parameter to TaskUpdateVite constructor
  • Remove service worker plugin and its imports from vite.generated.ts when offline build is not enabled
  • Use FrontendDependenciesScanner in TaskGeneratePackageJson to generate correct dev dependencies
  • Enhance TaskUpdatePackages for proper override handling
  • Move all workbox dependencies to workbox/package.json and only add when offline sw build is needed
  • Add overrides for workbox dependencies to package.json
  • Add overrides support to NodeUpdater
  • Remove empty vaadin.overrides from package.json

- Add PwaConfiguration parameter to TaskUpdateVite constructor
- Make service worker plugin only added when necessary in vite.generated.ts template
- Use FrontendDependenciesScanner in TaskGeneratePackageJson to generate correct dev dependencies
- Enhance TaskUpdatePackages for proper override handling
- Add overrides for workbox dependencies to package.json
- Add overrides support to NodeUpdater
@platosha platosha changed the title fix/workbox overrides fix: add package.json overrides for workbox dependencies Mar 25, 2026
@sonarqubecloud
Copy link

@github-actions
Copy link

Test Results

 1 386 files  ± 0   1 386 suites  ±0   1h 21m 34s ⏱️ - 6m 6s
 9 940 tests +21   9 869 ✅ +21  71 💤 ±0  0 ❌ ±0 
10 413 runs  +21  10 333 ✅ +21  80 💤 ±0  0 ❌ ±0 

Results for commit a70d08c. ± Comparison against base commit 0d03ea1.

This pull request removes 2 and adds 23 tests. Note that renamed tests count towards both.
com.vaadin.flow.server.frontend.NodeUpdaterTest ‑ getDefaultDevDependencies_excludesWorkbox_whenPwaDisabled
com.vaadin.flow.server.frontend.NodeUpdaterTest ‑ getDefaultDevDependencies_includesWorkbox_whenPwaEnabled
com.vaadin.flow.server.frontend.NodeUpdatePackagesWithByteCodeScannerTest ‑ generatePackageJson_overridesChanged_updaterIsModified
com.vaadin.flow.server.frontend.NodeUpdatePackagesWithByteCodeScannerTest ‑ generatePackageJson_sameOverrides_updaterIsNotModified
com.vaadin.flow.server.frontend.NodeUpdatePackagesWithFullCPCodeScannerTest ‑ generatePackageJson_overridesChanged_updaterIsModified
com.vaadin.flow.server.frontend.NodeUpdatePackagesWithFullCPCodeScannerTest ‑ generatePackageJson_sameOverrides_updaterIsNotModified
com.vaadin.flow.server.frontend.NodeUpdaterTest ‑ getDefaultDevDependencies_excludesWorkbox_whenPwaOfflineDisabled
com.vaadin.flow.server.frontend.NodeUpdaterTest ‑ getDefaultDevDependencies_includesWorkbox_whenPwaOfflineEnabled
com.vaadin.flow.server.frontend.NodeUpdaterTest ‑ getDefaultOverrides_includesWorkboxOverrides_whenPwaOfflineEnabled
com.vaadin.flow.server.frontend.NodeUpdaterTest ‑ getDefaultOverrides_returnsEmpty_whenPwaNull
com.vaadin.flow.server.frontend.NodeUpdaterTest ‑ getDefaultOverrides_returnsEmpty_whenPwaOfflineDisabled
com.vaadin.flow.server.frontend.TaskUpdatePackagesNpmTest ‑ generatePackageJsonHash_pnpmOverridesAdded_hashChanges
…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant