Skip to content

fix: Prevent multiple effect invocations when reading the same signal multiple times #23978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mshabarov wants to merge 6 commits into
base: main
Choose a base branch
from
+93 −4

Merge remote-tracking branch 'origin/multiple-effect-invocations' int…

8c1f174
Select commit
Loading
Failed to load commit list.
Open

fix: Prevent multiple effect invocations when reading the same signal multiple times #23978

Merge remote-tracking branch 'origin/multiple-effect-invocations' int…
8c1f174
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 25, 2026 in 1m 58s

Quality Gate passed

Issues
2575 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check failure on line 257 in flow-server/src/test/java/com/vaadin/flow/dom/ElementUtilTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0kZaLDYdn-O0VHWgvt&open=AZ0kZaLDYdn-O0VHWgvt&pullRequest=23978

Check warning on line 98 in flow-polymer-template/src/test/java/com/vaadin/flow/templatemodel/TemplateModelWithEncodersTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "TemplateModel"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0kZWU5Ydn-O0VHWgTo&open=AZ0kZWU5Ydn-O0VHWgTo&pullRequest=23978

Check warning on line 90 in flow-server/src/test/java/com/vaadin/flow/server/communication/MetadataWriterTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.io.IOException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0kZXnHYdn-O0VHWglQ&open=AZ0kZXnHYdn-O0VHWglQ&pullRequest=23978

Check warning on line 333 in flow-server/src/test/java/com/vaadin/flow/server/auth/AccessAnnotationCheckerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0kZX8oYdn-O0VHWgno&open=AZ0kZX8oYdn-O0VHWgno&pullRequest=23978

Check warning on line 491 in flow-server/src/test/java/com/vaadin/flow/internal/JacksonSerializerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce the number of assertions from 38 to less than 25. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0kZa07Ydn-O0VHWg1K&open=AZ0kZa07Ydn-O0VHWg1K&pullRequest=23978

Check warning on line 135 in flow-server/src/test/java/com/vaadin/flow/internal/StateTreeTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this lambda with method reference 'detachCount::incrementAndGet'. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0kZbA2Ydn-O0VHWg11&open=AZ0kZbA2Ydn-O0VHWg11&pullRequest=23978

Check failure on line 45 in flow-server/src/test/java/com/vaadin/flow/router/internal/ConfigureRoutesTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0kZbEBYdn-O0VHWg2S&open=AZ0kZbEBYdn-O0VHWg2S&pullRequest=23978

Check warning on line 141 in flow-server/src/test/java/com/vaadin/flow/shared/BrowserDetailsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "BrowserDetails"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0kZbUiYdn-O0VHWg30&open=AZ0kZbUiYdn-O0VHWg30&pullRequest=23978

Check warning on line 680 in flow-server/src/test/java/com/vaadin/flow/server/startup/RouteRegistryInitializerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0kZX4AYdn-O0VHWgm5&open=AZ0kZX4AYdn-O0VHWgm5&pullRequest=23978

Check warning on line 1801 in flow-server/src/test/java/com/vaadin/flow/dom/ElementJacksonTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this call to a deprecated class, it has been marked for removal. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0kZaRqYdn-O0VHWgxX&open=AZ0kZaRqYdn-O0VHWgxX&pullRequest=23978

Check warning on line 67 in flow-server/src/test/java/com/vaadin/flow/router/RouterLinkTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.NoSuchFieldException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0kZbNAYdn-O0VHWg3H&open=AZ0kZbNAYdn-O0VHWg3H&pullRequest=23978

Check warning on line 494 in flow-server/src/test/java/com/vaadin/flow/shared/BrowserDetailsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "BrowserDetails"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0kZbUiYdn-O0VHWg4y&open=AZ0kZbUiYdn-O0VHWg4y&pullRequest=23978

Check warning on line 81 in flow-polymer-template/src/test/java/com/vaadin/flow/templatemodel/TemplateModelProxyHandlerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "TemplateModelProxyHandler"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0kZWiuYdn-O0VHWgXb&open=AZ0kZWiuYdn-O0VHWgXb&pullRequest=23978

Check warning on line 494 in flow-server/src/test/java/com/vaadin/flow/shared/BrowserDetailsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "BrowserDetails"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0kZbUiYdn-O0VHWg4z&open=AZ0kZbUiYdn-O0VHWg4z&pullRequest=23978

Check warning on line 587 in flow-server/src/test/java/com/vaadin/flow/shared/BrowserDetailsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "BrowserDetails"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0kZbUiYdn-O0VHWg5C&open=AZ0kZbUiYdn-O0VHWg5C&pullRequest=23978

Check warning on line 575 in flow-server/src/test/java/com/vaadin/flow/server/VaadinSessionTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "session" which hides the field declared at line 106. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0kZYI0Ydn-O0VHWgok&open=AZ0kZYI0Ydn-O0VHWgok&pullRequest=23978

Check warning on line 263 in flow-server/src/test/java/com/vaadin/flow/dom/ElementTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0kZahhYdn-O0VHWgyW&open=AZ0kZahhYdn-O0VHWgyW&pullRequest=23978

Check warning on line 264 in flow-polymer-template/src/test/java/com/vaadin/flow/templatemodel/TemplateModelTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "PolymerTemplate"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0kZWmKYdn-O0VHWgZT&open=AZ0kZWmKYdn-O0VHWgZT&pullRequest=23978

Check warning on line 502 in flow-server/src/test/java/com/vaadin/flow/server/communication/StreamReceiverHandlerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this call to a deprecated class, it has been marked for removal. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0kZXevYdn-O0VHWgjg&open=AZ0kZXevYdn-O0VHWgjg&pullRequest=23978

Check warning on line 1122 in flow-server/src/test/java/com/vaadin/flow/dom/ElementJacksonTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0kZaRqYdn-O0VHWgwc&open=AZ0kZaRqYdn-O0VHWgwc&pullRequest=23978

Check warning on line 848 in flow-server/src/test/java/com/vaadin/flow/shared/BrowserDetailsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "BrowserDetails"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0kZbUiYdn-O0VHWg5v&open=AZ0kZbUiYdn-O0VHWg5v&pullRequest=23978

Check warning on line 58 in flow-server/src/test/java/com/vaadin/flow/server/communication/rpc/AttachTemplateChildRpcHandlerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0kZXXnYdn-O0VHWgiS&open=AZ0kZXXnYdn-O0VHWgiS&pullRequest=23978

Check warning on line 98 in flow-polymer-template/src/test/java/com/vaadin/flow/templatemodel/TemplateModelTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "TemplateModel"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0kZWmKYdn-O0VHWgYP&open=AZ0kZWmKYdn-O0VHWgYP&pullRequest=23978

Check warning on line 257 in flow-server/src/test/java/com/vaadin/flow/di/LookupInitializerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'jakarta.servlet.ServletException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0kZbQtYdn-O0VHWg3k&open=AZ0kZbQtYdn-O0VHWg3k&pullRequest=23978

Check warning on line 472 in flow-polymer-template/src/test/java/com/vaadin/flow/templatemodel/BeanModelTypeTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "ClientUpdateMode"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=vaadin_flow&issues=AZ0kZWeMYdn-O0VHWgXI&open=AZ0kZWeMYdn-O0VHWgXI&pullRequest=23978
View more details on SonarQubeCloud