Conversation
Expose the browser Screen Wake Lock API through Page methods, allowing server-side Java code to prevent the screen from dimming or locking for dashboards, kiosks, and presentations.
|
mcollovati
reviewed
Mar 26, 2026
| * listeners registered with {@link #addWakeLockReleaseListener} are | ||
| * notified. | ||
| */ | ||
| public void requestWakeLock() { |
Collaborator
There was a problem hiding this comment.
It would be good to have a way to be notified in case of error; for example, an optional callback parameter to be chained to the pending JS invocation. Or return a CompletableFuture
Comment on lines
+515
to
+517
| public PendingJavaScriptResult isWakeLockActive() { | ||
| return executeJs("return window.Vaadin.Flow.wakeLock.isActive()"); | ||
| } |
Collaborator
There was a problem hiding this comment.
What about a typed callback parameter instead of returning PendingJavaScriptResult? Or return a CompletableFuture<Boolean>?
| if (sentinel !== null) { | ||
| return; | ||
| } | ||
| sentinel = await navigator.wakeLock.request('screen'); |
Collaborator
There was a problem hiding this comment.
It would be good to propagate errors to the server so that the developers can immediately react on them, instead of having to do another call to isActive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the browser Screen Wake Lock API through Page methods, allowing server-side Java code to prevent the screen from dimming or locking for dashboards, kiosks, and presentations.