Open
Conversation
Allows reviewers to see documentation changes rendered on a live preview site before merging. Each PR gets its own Fly.io app that is automatically cleaned up when the PR closes.
No need for a multi-stage build with nginx when the project's own dev server works fine for preview purposes.
flyctl deploy doesn't support --internal-port, so the config needs to come from a generated fly.toml file.
Preview DeploymentThis PR has been deployed for preview. URL: https://docs-preview-pr-5327.fly.dev Built from c2b8f9e |
DSPublisher's dev server requires Maven at startup for license checking. The pro key is set as a Fly.io secret so it's available at runtime.
Avoids slow Maven downloads on every container startup by caching them in the image layer.
Avoids needing Maven/JDK entirely by using DSPublisher's build mode and serving the static output with serve.
Newer rollup versions disallow placing export between a decorator and a class declaration. The TC39 decorators spec requires export to come before the decorator.
This reverts commit 337769d.
Run vaadin:prepare-frontend during Docker build to generate vite.generated.ts and target/plugins/ that Vite needs at startup. Copy src/ for the license check class compilation. Pass VAADIN_PRO_KEY as a Fly secret and increase VM memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows reviewers to see documentation changes rendered on a live preview site before merging. Each PR gets its own Fly.io app that is automatically cleaned up when the PR closes.