Conversation
|
@sylvestre, this is util-linux. Why is the CI server attempting to build it for Windows and MacOS? |
|
I just noticed PR #226. I don't intend to trigger any conflicts. @sylvestre, how should I proceed? |
|
@koutheir could you please contribute to the other PR ? |
Does that mean abandoning the code of this pull request? |
|
i haven't looked which one is the best implementation |
|
I actually read the code of the other pull request, and given the significant difference in design decisions, I don't think the two PRs can be merged, without overriding most of the code of either implementations. |
|
OK. Too bad. |
|
I will have a deeper look |
|
@sylvestre, did you get a chance to look deeper? |
|
not yet, sorry |
|
could you please fix the build failure on other OS ? |
Should I remove the Windows and MacOS entries from the CI configuration? |
|
nope, fix your PR to make it pass on these archs (as much as possible) it was green before: https://github.com/uutils/util-linux/actions/runs/13933228399 |
Do you mean port the tools to these platforms? Or somehow exclude the tool from building? Or make it an empty crate? |
|
As much as possible, we want to support other OS. Here, i don't know if there are API to do the same on Windows and Mac |
|
For reference, these tools ( In the meantime, I'll try to force the tool to "compile" on platforms other than Linux, but I'll mark things as unimplemented, so if anybody tries to actually use them, they would get a reasonable error. |
|
sounds good, thanks! |
|
@sylvestre, I applied all your requests. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes #22.