fix(pm): Windows runtime fixes — PATH, execute, global dir, cache

[elrrrrrrr]

Summary

Follow-up to #2702. Fixes utoo runtime issues on Windows:

Changes

1. PATH separator (platform_const.rs, script.rs)

   • Use ; instead of : on Windows — : conflicts with drive letters like D:

2. execute_binary (execute.rs)

   • On Windows, prefer .cmd shim if exists, otherwise use sh to execute Unix shim scripts
   • Deduplicated cmd.args() per Gemini review

3. Global package dir (global_bin.rs)

   • Use <prefix>/node_modules on Windows instead of <prefix>/lib/node_modules

4. Platform constants (platform_const.rs)

   • Extract PATH_SEPARATOR and GLOBAL_NODE_MODULES constants to avoid scattered cfg!(windows)

5. Cross-drive cache (user_config.rs)

   • Detect when cache dir (e.g. C:\.cache\nm) is on a different drive than project (e.g. D:\project)
   • Fall back to cache on project's drive to enable hardlinks

Verified

• Windows e2e: egg install + build + 130 tests passed ✅
• Windows e2e: ant-design install + build ✅
• Windows e2e: ant-design-x install + build ✅
• All CI checks: 20/20 SUCCESS ✅

🤖 Generated with Claude Code

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces several critical fixes to improve the package manager's compatibility and functionality on Windows. The changes address issues related to environment variable path handling, binary execution, and the location of global package installations, ensuring a more robust and native experience for Windows users. These adjustments are essential for the correct operation of the package manager across different operating systems.

Highlights

• PATH separator: The PATH separator now correctly uses ; instead of : on Windows to avoid conflicts with drive letters.
• execute_binary: The execute_binary function now prefers .cmd shims on Windows and falls back to sh for Unix shim scripts, resolving 'not a valid Win32 application' errors.
• global package dir: The global package directory on Windows is now correctly set to <prefix>/node_modules instead of <prefix>/lib/node_modules.

Changelog

• crates/pm/src/helper/global_bin.rs
  • Implemented platform-specific logic for get_global_package_dir to return <prefix>/node_modules on Windows and <prefix>/lib/node_modules on Unix.
• crates/pm/src/service/execute.rs
  • Introduced conditional compilation for Windows to check for a .cmd shim alongside the binary path.
  • If a .cmd shim exists, it is executed directly.
  • If no .cmd shim is found, sh is used to execute the original binary path, assuming it's a Unix-style shim script.
  • Maintained existing Command::new(binary_path) behavior for non-Windows platforms.
• crates/pm/src/service/script.rs
  • Changed the path_separator variable in build_path_env to be conditionally set to ; for Windows and : for other operating systems.

Activity

• No human activity has occurred on this pull request since its creation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces several fixes for running on Windows. The changes correctly adjust the PATH separator, the global package directory path, and the binary execution logic for Windows environments. The code is functionally correct. The provided suggestion to refactor a section of the code for better readability and maintainability by reducing code duplication has been retained as it aligns with general best practices and does not contradict any specific rules.