Skip to content

TURBOPACK: load chunks references from runtime code#126

Merged
fireairforce merged 1 commit intoutoofrom
load-runtime-chunk-references
Mar 20, 2026
Merged

TURBOPACK: load chunks references from runtime code#126
fireairforce merged 1 commit intoutoofrom
load-runtime-chunk-references

Conversation

@fireairforce
Copy link
Member

load runtime code chunk references!!

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the runtime chunk loading mechanism in Turbopack by adjusting how non-CSS runtime chunks are handled. The change ensures that JavaScript runtime code references are correctly loaded and processed, rather than being skipped based on a prior assumption, thereby improving the robustness of the chunk loading process.

Highlights

  • Runtime JavaScript Chunk Loading: Enabled the loading of JavaScript runtime chunk references by modifying the loadChunk function. Previously, non-CSS runtime chunks were implicitly assumed to be present in the DOM, but now they will be properly loaded and resolved.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the chunk loading logic for runtime code. It removes the special case for JavaScript runtime chunks, which were previously assumed to be present in the DOM and not loaded. Now, they will be loaded via the default chunk loading mechanism. The special handling for CSS runtime chunks is maintained, but the code is refactored into a single conditional block, simplifying the logic.

@fireairforce fireairforce merged commit cc0c5bd into utoo Mar 20, 2026
13 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant