Skip to content

fix exception in FindConnectionByIdOrName() caused by GetProperties() #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karlhiramoto wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix exception in FindConnectionByIdOrName() caused by GetProperties() #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
627393d
Allow NetworkInterfaceType.GigabitEthernet interfaces
karlhiramoto Feb 7, 2014
e21f16b
Handle exceptions. GetProperties() and GetConfiguration() can throw …
karlhiramoto Feb 7, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 53 additions & 18 deletions IcsManagerLibrary/IcsManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,23 +17,34 @@ from nic in NetworkInterface.GetAllNetworkInterfaces()
where nic.Supports(NetworkInterfaceComponent.IPv4)
where (nic.NetworkInterfaceType == NetworkInterfaceType.Ethernet)
|| (nic.NetworkInterfaceType == NetworkInterfaceType.Wireless80211)
|| (nic.NetworkInterfaceType == NetworkInterfaceType.GigabitEthernet)
select nic;
}

public static NetShare GetCurrentlySharedConnections()
{
INetConnection sharedConnection = (
from INetConnection c in SharingManager.EnumEveryConnection
where GetConfiguration(c).SharingEnabled
where GetConfiguration(c).SharingConnectionType ==
tagSHARINGCONNECTIONTYPE.ICSSHARINGTYPE_PUBLIC
select c).DefaultIfEmpty(null).First();
INetConnection homeConnection = (
from INetConnection c in SharingManager.EnumEveryConnection
where GetConfiguration(c).SharingEnabled
where GetConfiguration(c).SharingConnectionType ==
tagSHARINGCONNECTIONTYPE.ICSSHARINGTYPE_PRIVATE
select c).DefaultIfEmpty(null).First();
INetConnection sharedConnection = null;
INetConnection homeConnection = null;
INetSharingEveryConnectionCollection connections = SharingManager.EnumEveryConnection;
foreach (INetConnection c in connections)
{
try
{

INetSharingConfiguration config = GetConfiguration(c);
if (config.SharingEnabled)
{
if (config.SharingConnectionType == tagSHARINGCONNECTIONTYPE.ICSSHARINGTYPE_PUBLIC)
sharedConnection = c;
else if (config.SharingConnectionType == tagSHARINGCONNECTIONTYPE.ICSSHARINGTYPE_PRIVATE)
homeConnection = c;
}
}
catch (System.Runtime.InteropServices.ExternalException)
{
}
}

return new NetShare(sharedConnection, homeConnection);
}

Expand Down Expand Up @@ -81,16 +92,40 @@ public static INetConnection FindConnectionByIdOrName(string shared)

public static INetConnection GetConnectionById(string guid)
{
return (from INetConnection c in GetAllConnections()
where GetProperties(c).Guid == guid
select c).DefaultIfEmpty(null).First();
INetSharingEveryConnectionCollection connections = GetAllConnections();
foreach (INetConnection c in connections)
{
try
{
INetConnectionProps props = GetProperties(c);
if (props.Guid == guid)
return c;
}
catch (System.Runtime.InteropServices.ExternalException)
{
// Ignore these It'ts known that Tunnel adapter isatap causes getProperties to fail.
}
}
return null;
}

public static INetConnection GetConnectionByName(string name)
{
return (from INetConnection c in GetAllConnections()
where GetProperties(c).Name == name
select c).DefaultIfEmpty(null).First();
INetSharingEveryConnectionCollection connections = GetAllConnections();
foreach (INetConnection c in connections)
{
try
{
INetConnectionProps props = GetProperties(c);
if (props.Name == name)
return c;
}
catch (System.Runtime.InteropServices.ExternalException)
{
// Ignore these It'ts known that Tunnel adapter isatap causes getProperties to fail.
}
}
return null;
}

}
Expand Down