Skip to content

Fix/warnings #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PaulKlint wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/warnings #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36ccaa4
Fix typechecker warnings
PaulKlint Mar 11, 2026
77c94cd
Fixes https://github.com/usethesource/rascal/issues/2442
PaulKlint Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/analysis/typepal/Collector.rsc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -956,11 +956,11 @@ Collector newCollector(str modelName, map[str,Tree] namedTrees, TypePalConfig co
if(logicalLoc != def.defined){
if(logicalLoc in logical2physical){
if(logical2physical[logicalLoc] != def.defined){
causes = [ info("Clone of `<def.id>`", logical2physical[logicalLoc]),
info("Clone of `<def.id>`", def.defined)
causes = [ info("First declaration of <prettyRole(def.idRole)> `<def.id>`", logical2physical[logicalLoc]),
info("Second declaration of <prettyRole(def.idRole)> `<def.id>`", def.defined)
];
// restrict clone location to first line for readability
messages += error("Remove code clone for <prettyRole(def.idRole)> `<def.id>`", limitLocToFirstLine(def.defined), causes=causes);
messages += error("Duplicate declaration of <prettyRole(def.idRole)> `<def.id>`", limitLocToFirstLine(def.defined), causes=causes);
}
}
logical2physical[logicalLoc] = def.defined;
Expand Down
12 changes: 6 additions & 6 deletions src/analysis/typepal/Exception.rsc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ module analysis::typepal::Exception
extend analysis::typepal::FailMessage;

data RuntimeException
= TypePalUsage(str reason) // TypePal used incorrectly
| TypePalUsage(str reason, list[loc] details) // TypePal used incorrectly, with additional details
| TypePalInternalError(str reason) // TypePal internal error
| TypeUnavailable() // Type is not available: used in control flow of solver
| checkFailed(list[FailMessage] msgs) // Type check failed: used in control flow of solver
| wrongTplVersion(str reason) // Outdated TPL version is used
= TypePalUsage(str msg) // TypePal used incorrectly
| TypePalUsage(str msg, list[loc] details) // TypePal used incorrectly, with additional details
| TypePalInternalError(str msg) // TypePal internal error
| TypeUnavailable() // Type is not available: used in control flow of solver
| checkFailed(list[FailMessage] msgs) // Type check failed: used in control flow of solver
| wrongTplVersion(str msg) // Outdated TPL version is used
;

data Exception
Expand Down
Loading