Conversation
Rexogamer
left a comment
Rexogamer
left a comment
There was a problem hiding this comment.
see also my recent ping on the Clerotri server
m-doescode
force-pushed
the
feature/reaction-viewer
branch
from
06017b8 to
182c4a4
Compare
| }, | ||
| openViewReactions: (m: Message | null, e: string | null) => { | ||
| console.log( | ||
| `[FUNCTIONS] Tried to run uninitialised function openViewReaction (args: ${m}, ${e})` |
There was a problem hiding this comment.
tiny typo:
| `[FUNCTIONS] Tried to run uninitialised function openViewReaction (args: ${m}, ${e})` | |
| `[FUNCTIONS] Tried to run uninitialised function openViewReactions (args: ${m}, ${e})` |
|
|
||
| const sheetRef = useRef<BottomSheetCore>(null); | ||
|
|
||
| setFunction('openViewReactions', async (m: Message | null, emoji: string) => { |
There was a problem hiding this comment.
unused async - also the types here don't quite match the Generic.tsx placeholder
| setFunction('openViewReactions', async (m: Message | null, emoji: string) => { | |
| setFunction('openViewReactions', (m: Message | null, emoji: string | null) => { |
|
do you still want to work on this? |
|
Yes! Sorry, I was waiting on your feedback. It's been a while but I remember you mentioned wanting to write your own emoji picker? Unfortunately I don't think I'll be able to work on it this week, but I'll set a reminder for next week. |
|
no worries! I haven't made a decision there, but the viewer should be addable without picking functionality so that's not a blocker here |
|
oh, then i think its been ready for a while... I guess I should've probably let you know haha If so, I'll take a look tomorrow and see if i can rebase it. Thanks for your patience! |
m-doescode
force-pushed
the
feature/reaction-viewer
branch
from
afaf0a3 to
9033d7c
Compare
Signed-off-by: m-doescode <80221594+m-doescode@users.noreply.github.com>
m-doescode
force-pushed
the
feature/reaction-viewer
branch
from
9033d7c to
78b3dae
Compare
| }, | ||
| openViewReactions: (m: Message | null, e: string | null) => { | ||
| console.log( | ||
| `[FUNCTIONS] Tried to run uninitialised function openViewReaction (args: ${m}, ${e})` |
2 participants
As requested in #45 (review), originally as part of #45
Adds a reaction viewer, displaying which users reacted with which emojis by long-pressing a reaction under a message.
Please make sure to check the following tasks before opening and submitting a PR