Open
Conversation
- Методы выборки из таблицы книг.
- Добавление Spring Shell.
- Добавление Shell команд.
- Разделение методов на отдельные модули. - Добавление тестов.
- Изменены запросы книг. - Добавление внешних ключей для таблицы книг. - Изменение сущности Book. - Изменение типа id.
- Использование @jdbcTest.
- Изменение тестов.
- Доработка тестов.
- Связи OneToOne изменены на ManyToOne.
# Conflicts: # README.md # src/main/java/ru/otus/mkulikov/app/dao/AuthorDaoJpa.java # src/test/java/ru/otus/mkulikov/app/dao/AuthorDaoJpaTest.java # src/test/java/ru/otus/mkulikov/app/dao/BookDaoJpaTest.java
- Доработка скриптов.
- Добавление тестов.
- Добавление возможности редактирования записей в html.
- Доработки страниц.
kataus
reviewed
Sep 23, 2019
|
|
||
| public static void main(String[] args) throws Exception { | ||
| SpringApplication.run(Application.class); | ||
| //Console.main(args); |
There was a problem hiding this comment.
Не оставляйте закоментированный код. это некрасиво
kataus
reviewed
Sep 23, 2019
|
|
||
| private final BookManageService bookManageSevice; | ||
|
|
||
| @ShellMethod(key = {"getBookById"}, value = "Select book by id.") |
There was a problem hiding this comment.
МОжно было подчистить чтобы не усложнять текущую задачу. Git сохранит историю
kataus
reviewed
Sep 23, 2019
| <tbody> | ||
| <tr> | ||
| <td> | ||
| <form action="/author/list"> |
There was a problem hiding this comment.
Это всё можно было вынести в отдельный шаблон и подгружать везде где надо меню сделать, чтобы не повторяться из формы в форму
kataus
reviewed
Sep 23, 2019
| <meta name="viewport" content="width=device-width, initial-scale=1.0"/> | ||
|
|
||
| <!-- See configuration in WebMvConfig.java --> | ||
| <link th:href="@{/bootstrap/css/bootstrap.min.css}" |
There was a problem hiding this comment.
Где-то есть бутстрап, где-то нет. В проектах должно быть однообразие, иначе сложно поддерживать
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.