Open
Conversation
- Методы выборки из таблицы книг.
- Добавление Spring Shell.
- Добавление Shell команд.
- Разделение методов на отдельные модули. - Добавление тестов.
- Изменены запросы книг. - Добавление внешних ключей для таблицы книг. - Изменение сущности Book. - Изменение типа id.
- Использование @jdbcTest.
- Изменение тестов.
- Доработка тестов.
- Связи OneToOne изменены на ManyToOne.
# Conflicts: # README.md # src/main/java/ru/otus/mkulikov/app/dao/AuthorDaoJpa.java # src/test/java/ru/otus/mkulikov/app/dao/AuthorDaoJpaTest.java # src/test/java/ru/otus/mkulikov/app/dao/BookDaoJpaTest.java
- Доработка скриптов.
- Добавление классов для обработки сущности Comment и покрытие тестами.
# Conflicts: # README.md # src/main/java/ru/otus/mkulikov/Application.java # src/main/java/ru/otus/mkulikov/app/dao/AuthorDao.java # src/main/java/ru/otus/mkulikov/app/dao/AuthorDaoJpa.java # src/main/java/ru/otus/mkulikov/app/dao/GenreDao.java # src/main/java/ru/otus/mkulikov/app/dao/GenreDaoJpa.java # src/main/java/ru/otus/mkulikov/app/service/AuthorManageServiceImpl.java # src/main/java/ru/otus/mkulikov/app/service/BookManageSeviceImpl.java # src/main/java/ru/otus/mkulikov/app/service/GenreManageServiceImpl.java # src/test/java/ru/otus/mkulikov/app/dao/AuthorDaoJpaTest.java # src/test/java/ru/otus/mkulikov/app/dao/BookDaoJpaTest.java # src/test/java/ru/otus/mkulikov/app/dao/GenreDaoJpaTest.java # src/test/resources/schema-test.sql
- Подключение liquibase.
- Возвращаю Optional в DAO.
- Использование @NamedEntityGraph.
- Убрана liquibase. - Переработка тестов.
stvort
approved these changes
Aug 22, 2019
|
|
||
| <dependency> | ||
| <groupId>de.flapdoodle.embed</groupId> | ||
| <artifactId>de.flapdoodle.embed.mongo</artifactId> |
Owner
Author
There was a problem hiding this comment.
Да. Подразумевалось, что используется и для самого приложения.
| data: | ||
| mongodb: | ||
| uri: mongodb://localhost | ||
| port: 27017 |
There was a problem hiding this comment.
Если встроенная монга запустится с такими настройками она выбьет штатную службу сервера. Поэтому для тестов (и основного приложения если планируется запуск на встроенной монге) нужно выставлять порт 0
| void init() { | ||
| authorDao.save(getAuthor(ID_1)); | ||
| authorDao.save(getAuthor(ID_2)); | ||
| authorDao.save(getAuthor(ID_3)); |
There was a problem hiding this comment.
Все, что не тестируем лучше делать через MongoTemplate
|
|
||
| @Override | ||
| public int deleteAuthor(String id) { | ||
| authorDao.deleteById(id); |
| banner: | ||
| location: "classpath:banner.txt" | ||
|
|
||
| jpa: |
pom.xml
Outdated
| <groupId>org.springframework.data</groupId> | ||
| <artifactId>spring-data-jpa</artifactId> | ||
| <version>2.0.8.RELEASE</version> | ||
| </dependency> |
There was a problem hiding this comment.
В pom много лишнего. Некоторые зависимости можно убрать
|
|
||
| @Id | ||
| private String id; | ||
| private String surname; |
There was a problem hiding this comment.
Считается хорошим тоном размечать поля аннотацией @Field с именем поля в коллекции
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.