Skip to content

Fix from_serializable_dict to ignore plain data dicts with "type" key #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
unclecode merged 1 commit into from
Mar 7, 2026
+12 −2
Merged

Fix from_serializable_dict to ignore plain data dicts with "type" key #1803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions crawl4ai/async_configs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,8 +242,18 @@ def from_serializable_dict(data: Any) -> Any:
if isinstance(data, (str, int, float, bool)):
return data

# Handle typed data
if isinstance(data, dict) and "type" in data:
# Handle typed data.
# Only enter the typed-object path for dicts that match the shapes produced
# by to_serializable_dict(): {"type": "<ClassName>", "params": {...}} or
# {"type": "dict", "value": {...}}. Plain business dicts that happen to
# carry a "type" key (e.g. JSON-Schema fragments, JsonCss field specs like
# {"type": "text", "name": "..."}) have neither "params" nor "value" and
# must fall through to the raw-dict path below so they are passed as data.
if (
isinstance(data, dict)
and "type" in data
and ("params" in data or (data["type"] == "dict" and "value" in data))
):
# Handle plain dictionaries
if data["type"] == "dict" and "value" in data:
return {k: from_serializable_dict(v) for k, v in data["value"].items()}
Expand Down