Skip to content

Fix/exclude test dts from dist#18

Merged
umsungjun merged 3 commits intomainfrom
fix/exclude-test-dts-from-dist
Mar 24, 2026
Merged

Fix/exclude test dts from dist#18
umsungjun merged 3 commits intomainfrom
fix/exclude-test-dts-from-dist

Conversation

@umsungjun
Copy link
Copy Markdown
Owner

@umsungjun umsungjun commented Mar 24, 2026

Summary by CodeRabbit

  • Documentation

    • Added SEO guidance for client-side rendered applications, describing how to set baseline metadata in HTML and how the library overrides these at runtime for route-specific pages.
  • Chores

    • Version updated to 1.6.0-0.
    • Updated build configuration to exclude test files from TypeScript declarations.

umsungjun and others added 3 commits March 24, 2026 12:47
테스트 파일(.d.ts)이 dist/test/에 포함되어 npm 패키지에 불필요한 파일이 배포되는 문제를 수정

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-head-safe Ready Ready Preview, Comment Mar 24, 2026 3:59am

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 24, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7da00a5b-0475-4a50-8a7f-d42a5817f1fd

📥 Commits

Reviewing files that changed from the base of the PR and between f3ec899 and e3c0730.

📒 Files selected for processing (4)
  • README.ko.md
  • README.md
  • package.json
  • vite.config.ts

📝 Walkthrough

Walkthrough

Documentation updates added SEO guidance for Client-Side Rendering applications, including baseline meta tags in index.html and runtime overrides via react-head-safe. Package version bumped to 1.6.0-0, and build configuration updated to exclude test files from declaration generation.

Changes

Cohort / File(s) Summary
Documentation Updates
README.md, README.ko.md
Added "Important: SEO in CSR Applications" sections documenting the two-step behavior: static defaults in index.html for non-JS crawlers, and runtime overrides by react-head-safe for JS-capable clients.
Package Metadata
package.json
Version bumped from 1.5.0 to 1.6.0-0.
Build Configuration
vite.config.ts
Added exclude: ['src/test/**'] pattern to vite-plugin-dts options to omit test files from TypeScript declaration generation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Poem

🐰 A hop through docs, so clear and bright,
SEO tales from CSR's height,
Version bumps and configs aligned,
Test files tucked, no clutter to find!

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/exclude-test-dts-from-dist

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@umsungjun umsungjun merged commit 2651803 into main Mar 24, 2026
4 of 5 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants