Drop BCLConvert manager from stateless/stateful stacks#1047
Merged
Conversation
Also removed a bunch of stateful stacks that weren't taken the first time around
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the BCLConvert manager stack from both the stateless and stateful stack collections by commenting out or deleting the instantiation code. Additionally, it removes several stateful pipeline table stacks that were previously active.
Key changes:
- Commented out the BclConvertManagerStack instantiation in the stateless stack collection
- Removed instantiation of multiple stateful stacks: Cttsov2Icav2PipelineTable, OraCompressionIcav2PipelineTable, BclConvertTable, PierianDxPipelineTable, OncoanalyserNfPipelineTable, and SashNfPipelineTable
- Cleaned up imports by removing unused class imports while retaining their Props type imports
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/workload/stateless/statelessStackCollectionClass.ts | Moved BclConvertManagerStack instantiation from active code to commented section |
| lib/workload/stateful/statefulStackCollectionClass.ts | Removed instantiation of multiple pipeline table stacks and cleaned up imports to remove unused class imports |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removed a bunch of stateful stacks that weren't taken the first time around