Skip to content

[CTA] Updated CTA to work with uids_base#946

Open
bspeare wants to merge 15 commits into4.xfrom
cta_alignment_fixes
Open

[CTA] Updated CTA to work with uids_base#946
bspeare wants to merge 15 commits into4.xfrom
cta_alignment_fixes

Conversation

@bspeare
Copy link
Copy Markdown
Contributor

@bspeare bspeare commented Nov 18, 2024

How to test

  1. Code review
  2. Run through all the controls on http://localhost:6006/?path=/docs/components-cta--docs. Note, the inline version will only work with container queries. Move to item 4 for inline testing.
  3. Test background colors use both the cta background color and the container background color and verify everything is visible.
  4. Test container queries on "inline" version. Got to http://localhost:6006/?path=/story/components-cta--grid and change orientation to "inline" and test that it appears centered in three column grid. Remove "grid type" class and confirm that CTA appears inline.

@bspeare bspeare changed the title [CTA] Updated CTA to work with alignment classes [CTA] Updated CTA to work with uids_base Nov 20, 2024
@bspeare bspeare marked this pull request as ready for review November 20, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant