Open
Conversation
MarcusZuber
changed the title
MarcusZuber
force-pushed
the
add-experiment-remove-device-from-log
branch
from
c73ec81 to
d4dc1be
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #555 +/- ##
==========================================
+ Coverage 82.89% 82.93% +0.03%
==========================================
Files 133 133
Lines 10933 10957 +24
==========================================
+ Hits 9063 9087 +24
Misses 1870 1870 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tfarago
requested changes
Aug 28, 2025
Contributor
tfarago
left a comment
tfarago
left a comment
There was a problem hiding this comment.
Just fix the pep8 issues please and merge.
Contributor
|
Also a word in the documentation about adding and removing devices to/from logs would be nice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds high-level function to remove devices from the logging within the experiment.