Same plugin-manager is used in all uca-camera instances#554
Open
MarcusZuber wants to merge 2 commits intomasterfrom
Open
Same plugin-manager is used in all uca-camera instances#554MarcusZuber wants to merge 2 commits intomasterfrom
MarcusZuber wants to merge 2 commits intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #554 +/- ##
=======================================
Coverage 82.89% 82.89%
=======================================
Files 133 133
Lines 10933 10933
=======================================
Hits 9063 9063
Misses 1870 1870 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
When you ask why I didn't create the instance in the class body: Then I have to import gi.xxx globally, which we anted to prevent since we do not want to have it as hard dependency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used for ufo-kit/libuca#102 . (There the plugin manager keeps track of the uca-net-sub-cameras, which require the same plugin manager instance)