Open
Conversation
Parameters emit signals when the value and limits is changed by the user.
e6b807a to
7926fe0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #548 +/- ##
==========================================
- Coverage 82.85% 82.83% -0.02%
==========================================
Files 133 133
Lines 10928 10951 +23
==========================================
+ Hits 9054 9071 +17
- Misses 1874 1880 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Works only with python3.10+. 3.9 will be EOL this October. I don't think we will do a new realease before... |
Contributor
|
Doesn't psutil work only on linux? I get the motivation but the concrete cases you mentioned could be also handled without signals, or? Let's discuss this Friday in the meeting. |
Member
Author
|
I did' t add psutil here... Sure, lets discuss it on Friday. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking for an elegant way to connect different Parameterizable-Parameters and had this idea.
This uses https://github.com/nexconnectio/pynnex which implements qt-like signals and slots and is quite light-weight. Currently, the development is quite active and looks clean.
Example:
One motivation for this would be to couple experiment parameters with addon-parameters (the number of the online-reco couples with the num_projections of the CT experiment).
TODO: