Open
Conversation
Multiple states (instead on only 'state') can be used in concert.base.Parameterizable. This can be useful if the Device can be represented by multiple independent FSMs. The *check*- and *transition*-function now have an additional parameter *state_name*, where the name of the corresponding state can be set.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #533 +/- ##
==========================================
+ Coverage 88.36% 88.48% +0.11%
==========================================
Files 120 124 +4
Lines 8306 8481 +175
==========================================
+ Hits 7340 7504 +164
- Misses 966 977 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Tests fail due to race-condition when motion is started. Have to find a elegant solution for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODOs:
About the multiple states:
We use multiple devices, that are composed of sub-devices, where the state-machine can be split in multiple state-machines. Therefore, I introduced the possibility to use multiple states.