addon for grating stepping with a sin fit#513
Open
MarcusZuber wants to merge 2 commits intomasterfrom
Open
Conversation
Codecov ReportBase: 88.36% // Head: 88.37% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #513 +/- ##
=======================================
Coverage 88.36% 88.37%
=======================================
Files 120 120
Lines 8306 8347 +41
=======================================
+ Hits 7340 7377 +37
- Misses 966 970 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
|
I fixed flake8 and showed you how I do parentheses organization now (it's taken from some code checker, forgot which). It leads to longer code but is way more readable and doesn't break the formatting due to new positions of line breaks when you add new parameters, which is very nice. What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experiment addon that performs a sin-fit for the grating stepping.