Install parameters on instance instead of class#510
Open
MarcusZuber wants to merge 1 commit intomasterfrom
Open
Install parameters on instance instead of class#510MarcusZuber wants to merge 1 commit intomasterfrom
MarcusZuber wants to merge 1 commit intomasterfrom
Conversation
1f70c2d to
5d6c647
Compare
Member
Author
|
@tfarago : Do you see any general problems here? I will also add a few tests for this later. |
Contributor
|
What is the difference between |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should attach the parameters to the single instances and not to the class.
First tests are working:
The actual use-case of this is, when employing different uca-cameras.
With the class-wide implementation, each of the
concert.devices.camera.uca.Cameraadds all plugin-parameters to the uca.Camera class.