adjusting login.html to match new google sign-in migration#84
Open
LorenzoTomaz wants to merge 3 commits intoudacity:masterfrom
Open
adjusting login.html to match new google sign-in migration#84LorenzoTomaz wants to merge 3 commits intoudacity:masterfrom
LorenzoTomaz wants to merge 3 commits intoudacity:masterfrom
Conversation
|
udacity doesn't even merge it's own employee pull requests to fix it's none working code , fantastic. thanks udacity for making learning such a horrible experience |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While i was building one of my udacity full stack nanodegree's project i realize that the code for login.html present in ud330/Lesson3/step3/templates/ was not working as suppose to, so after reading the new documentation for the google+ sign-in i've found a better way to construct login.html. The changes for the google+ sign-in authentication system can be viewed in https://developers.google.com/identity/sign-in/web/quick-migration-guide