Skip to content

Initial unit test coverage of shared tlsserver module. #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonasbardino wants to merge 3 commits into
base: next
Choose a base branch
from
Open

Initial unit test coverage of shared tlsserver module. #491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a11f3ac
Initial unit test coverage of shared tlsserver module.
jonasbardino Mar 16, 2026
a77790a
Sync log validation with built-in ssl version.
jonasbardino Mar 16, 2026
2b9ef68
Rework `tlsserver` unit tests to use the proper TLS module with a bog…
jonasbardino Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mig/shared/tlsserver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# --- BEGIN_HEADER ---
#
# tlsserver - Shared functions for all SSL/TLS-secured servers
# Copyright (C) 2003-2021 The MiG Project lead by Brian Vinter
# Copyright (C) 2003-2026 The MiG Project by the Science HPC Center at UCPH
#
# This file is part of MiG.
#
Expand All @@ -20,7 +20,7 @@
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

Check warning on line 23 in mig/shared/tlsserver.py

View workflow job for this annotation

GitHub Actions / Style check python and annotate 

line too long (81 > 80 characters)
#
# -- END_HEADER ---
#
Expand Down Expand Up @@ -120,7 +120,7 @@
curves to take advantage of this optional improved security feature""")

if not pfs_available:
_logger.warning("""No Perfect Forward Secrecy with neither

Check warning on line 123 in mig/shared/tlsserver.py

View workflow job for this annotation

GitHub Actions / Style check python and annotate 

trailing whitespace
dhparams nor elliptic curves available.""")

ssl_ctx.set_ciphers(ciphers)
Expand Down Expand Up @@ -215,7 +215,7 @@
curves to take advantage of this optional improved security feature""")

if not pfs_available:
_logger.warning("""No Perfect Forward Secrecy with neither

Check warning on line 218 in mig/shared/tlsserver.py

View workflow job for this annotation

GitHub Actions / Style check python and annotate 

trailing whitespace
dhparams nor elliptic curves available.""")

ssl_ctx.set_cipher_list(ciphers)
Expand Down
Loading
Loading