Conversation
|
@sebacruz Thanks for the PR! I'll pull it down and take a look - we may need to make express and fastify peer dependencies in order to not require apps to be dependent on both. |
tzellman
left a comment
There was a problem hiding this comment.
The project currently uses the LTS version of node (defined in the .nvmrc file). We'll have to update the PR to use that version so that the lock file doesn't use version 2.
|
The Additionally, we will want to orchestrate the test suite so that both express and fastify are tested against. I'll need to dig in a little to see how this would make the most sense to do. 👍 |
|
@tzellman thank you for you review. I've already been working on changes that you suggested, can you confirm that they are ok? |
I am trying to add support for
fastifybut i'm just starting to use this package. Are there any other files that I need to modify?