Output json in nested structure#86
Conversation
|
Do you think this should just be the default? |
|
Yeah! If you're comfortable with the breaking change I could either swap it over the other way (eg. |
yep! that's fine with me. if you note the "breaking change" in the changeset it'll show up in the release notes and I think that's sufficient. Let's just remove flat entirely and conform with other ecosystem tools on this. It's not something I have a reason to deviate on afaik. Just was the arbitrary decision I made at the time of the initial implementation. |
4747806 to
6c68b0d
Compare
`gen-emit` now writes schemas into a nested directory structure based on the NSID (e.g. `com/atproto/repo/strongRef.json` instead of `com.atproto.repo.strongRef.json`). This is the layout expected by goat, lex, lpm, and others.
6c68b0d to
5ecc8b7
Compare
|
Rejigged to make it a permanent swap out to directory-based output 😊 Ready for review @tylersayshi ! |
tylersayshi
left a comment
There was a problem hiding this comment.
otherwise looks good, thanks!
gen-emitnow writes schemas into a nested directory structure based on the NSID (e.g.com/atproto/repo/strongRef.jsoninstead ofcom.atproto.repo.strongRef.json).This is the layout used by goat, lex, lpm, and others.