allow users to change initial stream position#40
Open
brenol wants to merge 2 commits intotwitchscience:masterfrom
Open
allow users to change initial stream position#40brenol wants to merge 2 commits intotwitchscience:masterfrom
brenol wants to merge 2 commits intotwitchscience:masterfrom
Conversation
brenol
force-pushed
the
allow-users-to-change-initial-stream-position
branch
from
6c89097 to
e728d05
Compare
brenol
force-pushed
the
allow-users-to-change-initial-stream-position
branch
from
e728d05 to
ea8cab9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow users to change the initial position from the stream. I think there are way better ways but I was unable to see all of them. This should close #31, even though it's a mix of position in stream + shard check frequency, which takes up to 5 minutes in the default behavior to trigger.
Also, this tries to be compatible with the current behavior 100%.