Skip to content

[pull] master from php:master#846

Merged
pull[bot] merged 9 commits intoturkdevops:masterfrom
php:master
Apr 7, 2026
Merged

[pull] master from php:master#846
pull[bot] merged 9 commits intoturkdevops:masterfrom
php:master

Conversation

@pull
Copy link
Copy Markdown

@pull pull bot commented Apr 7, 2026

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

DanielEScherzer and others added 9 commits April 7, 2026 08:31
Remove incorrect inline comment that using "double" as the type is deprecated;
this comment was added in 929ae94 when support
for "float" was included, but the use of "double" was never actually
deprecated.

[skip ci]
…_names change (GH-21635)

OnUpdateCommaList called zend_observer_remove/add_begin_handler without
checking whether observer data was initialized. This null-dereferenced
when the function had never been called (no runtime cache), and hit
ZEND_UNREACHABLE() when observe_all had already installed the same
handler.

Guard both the remove and add blocks with runtime cache checks. Remove
existing handlers before re-adding to prevent slot overflow from
duplicates.

Fixes GH-16811
Having these in the make file is very annoying, because it requires rebuilding
from scratch and rerunning tests just to see if some flag is effective.
* PHP-8.2:
  curl: add support for brotli and zstd on Windows
* PHP-8.3:
  curl: add support for brotli and zstd on Windows
* PHP-8.4:
  curl: add support for brotli and zstd on Windows
* PHP-8.5:
  curl: add support for brotli and zstd on Windows
@pull pull bot locked and limited conversation to collaborators Apr 7, 2026
@pull pull bot added the ⤵️ pull label Apr 7, 2026
@pull pull bot merged commit f05b156 into turkdevops:master Apr 7, 2026
1 of 3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants