Skip to content

Fix fwd declared types registering multiple times#184

Open
ahueck wants to merge 1 commit intodevelfrom
fix/global-naming
Open

Fix fwd declared types registering multiple times#184
ahueck wants to merge 1 commit intodevelfrom
fix/global-naming

Conversation

@ahueck
Copy link
Copy Markdown
Contributor

@ahueck ahueck commented Mar 31, 2026

Fwd declared types where registered multiple times in lulesh2.0-AD. Considering potential "_fwd" for the name in getOrInsertGlobal call should fix this.

Details

Runtime was called with "null" type info.

  • Before
nm lulesh2.0 | grep _fwd
...
00000000000a49a0 V _typeart__ZTSSt8ios_base_fwd
00000000000a55e0 V _typeart__ZTSSt8ios_base_fwd.59
                 v _typeart__ZTSSt8ios_base_fwd.66
  • After
nm lulesh2.0 | grep _fwd
...
00000000000a49a0 V _typeart__ZTSSt8ios_base_fwd

@coveralls
Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 23807897687

Details

  • 28 of 28 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 90.228%

Files with Coverage Reduction New Missed Lines %
lib/runtime/GlobalTypeDefCallbacks.cpp 1 95.61%
lib/typelib/TypeDB.cpp 1 78.35%
Totals Coverage Status
Change from base Build 20399623426: -0.02%
Covered Lines: 4866
Relevant Lines: 5393

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants