Skip to content

Add failing transcription tests #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
git-staus wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add failing transcription tests #45

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
212861f
Add a failing test for accented capitals
git-staus Mar 3, 2026
12d843f
Add a failing test for Pinyin V
git-staus Mar 3, 2026
6fc24f8
Add passing variants of the failing tests
git-staus Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions tests/test_transcriptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ class TestConvertFunctions(unittest.TestCase):
accented_pinyin_spaced = "Wǒ shì yī gè měi guó rén."
zhuyin = "ㄨㄛˇ ㄕˋ ㄧ ㄍㄜˋ ㄇㄟˇ ㄍㄨㄛˊ ㄖㄣˊ."
ipa = "wɔ˧˩˧ ʂɨ˥˩ i˥ kɤ˥˩ meɪ˧˩˧ kwɔ˧˥ ʐən˧˥."
uppercase_accented_pinyin = "Ài Àn Ào Ái È Èr É Ér Ā Āi Ēn Ō Ōu"
uppercase_accented_zhuyin = "ㄞˋ ㄢˋ ㄠˋ ㄞˊ ㄜˋ ㄦˋ ㄜˊ ㄦˊ ㄚ ㄞ ㄣ ㄛ ㄡ"

def test_numbered_to_accented(self):
accented_pinyin = trans.to_pinyin(self.numbered_pinyin)
Expand Down Expand Up @@ -193,3 +195,17 @@ def test_issue_27(self):
zhuyin = "ㄊㄟ"

self.assertEqual(zhuyin, trans.pinyin_to_zhuyin(pinyin))

def test_uppercase_accented_pinyin_to_zhuyin(self):
zhuyin = trans.pinyin_to_zhuyin(self.uppercase_accented_pinyin)
self.assertEqual(zhuyin, self.uppercase_accented_zhuyin)

def test_pinying_v_to_zhuyin(self):
self.assertEqual(trans.pinyin_to_zhuyin("lvè"), "ㄌㄩㄝˋ")

def test_lowercase_accented_pinyin_to_zhuyin(self):
zhuyin = trans.pinyin_to_zhuyin(self.uppercase_accented_pinyin.lower())
self.assertEqual(zhuyin, self.uppercase_accented_zhuyin)

def test_pinying_u_with_diaeresis_to_zhuyin(self):
self.assertEqual(trans.pinyin_to_zhuyin("lüè"), "ㄌㄩㄝˋ")