fix: skip MSP pair generation for net-label-only nets (issue #79)

[cccignore]

/claim #79

Problem

Nets connected only via netConnections that have availableNetLabelOrientations configured were incorrectly queued for wire-trace generation. This produced spurious trace lines alongside (or instead of) the net labels that should represent the connection — the repro61 bug.

Root Cause

MspConnectionPairSolver built queuedDcNetIds from Object.keys(netConnMap.netMap), which includes every net — including purely label-only ones like GND/VCC.

Fix

Filter queuedDcNetIds to keep only nets that actually need wire traces:

• Keep — nets with at least one pin in directConnections (explicit wire always wins)
• Keep — nets in netConnections with no label orientation configured (no other way to show the connection)
• Skip — nets in netConnections whose user-facing net ID appears in availableNetLabelOrientations — NetLabelPlacementSolver handles these

this.queuedDcNetIds = Object.keys(netConnMap.netMap).filter((netId) => {
  const connectedIds = netConnMap.getIdsConnectedToNet(netId) as string[]
  const hasDirect = connectedIds.some((id) => directlyWiredPinIds.has(id))
  if (hasDirect) return true
  const hasLabelOrientation = connectedIds.some((id) => netLabelOrientedNets.has(id))
  return !hasLabelOrientation
})

Why connectedIds contains the net label string: ConnectivityMap treats the user-provided netId (e.g. "GND") as just another member of the connectivity group, so getIdsConnectedToNet returns it alongside the pin IDs.

Why this is better than PR #162

PR #162 filters on directlyWiredPinIds alone, which removes all netConnections nets when directConnections is empty — leaving MspConnectionPairSolver_repro2-style circuits with no connections at all. This fix only removes nets that have an explicit label orientation configured.

Tests

• MspConnectionPairSolver_issue79.test.ts — 3 unit tests:
  1. Net-label-only net (GND in netConnections + orientation) → 0 MSP pairs
  2. Net in netConnections without orientation → still gets MSP pair
  3. Net in both directConnections and netConnections → keeps pair
• SchematicTracePipelineSolver_repro_issue79.test.ts — full pipeline: VCC/GND produce no spurious traces, net labels are placed
• MspConnectionPairSolver_repro1 — expected pair count updated 4 → 2 (GND was net-label-only)
• 7 SVG snapshots updated — spurious GND/VCC traces removed from example01, 12, 13, 15, 16, 21, 22
• Demo page: SchematicTracePipelineSolver_issue79.page.tsx

All 53 tests pass, 0 fail.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
schematic-trace-solver	Ready	Preview, Comment	Apr 10, 2026 8:56am

[cccignore]

Hi! Could you take a look at this PR when you have a chance? It fixes issue #79 by filtering out net-label-only nets from the MSP pair and long-distance pair generation pipelines. All 53 tests pass and CI is green. Thanks!