fix: New Phase To combine same-net trace segments that are close together#169
Open
ledgerpilot wants to merge 3 commits intotscircuit:mainfrom
Open
fix: New Phase To combine same-net trace segments that are close together#169ledgerpilot wants to merge 3 commits intotscircuit:mainfrom
ledgerpilot wants to merge 3 commits intotscircuit:mainfrom
Conversation
… segments that are close
… segments that are close
… segments that are close
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29
What changed
This fix introduces a new pipeline phase,
TraceSegmentMergeSolver, which combines same-net trace segments that are close together. The solver iteratively attempts to merge trace endpoints that belong to the same net and are within a small snap threshold, until no further merges can be made.Files modified
lib/types/SolvedTrace.tslib/solvers/TraceSegmentMergeSolver/TraceSegmentMergeSolver.tslib/solvers/TraceSegmentMergeSolver/index.tsAutomated PR — please review.