Skip to content

Change CI runner from ubuntu-latest to self-hosted #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vsilent wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change CI runner from ubuntu-latest to self-hosted #81

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
282fef2
Change CI runner from ubuntu-latest to self-hosted
vsilent Mar 26, 2026
1a6ae52
Merge branch 'master' into vsilent-patch-1
vsilent Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ on:
jobs:
build-and-test:
name: Build & Test (features=${{ matrix.features }})
runs-on: ubuntu-latest
#runs-on: ubuntu-latest
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping the old runs-on line commented out adds noise and can drift from reality. If you want to preserve the previous value, consider removing the commented line and capturing the reasoning in a short comment (or in PR description/docs) instead.

Suggested change
#runs-on: ubuntu-latest
# Run on self-hosted runner (requires project-specific environment, e.g. Docker)

Copilot uses AI. Check for mistakes.
runs-on: self-hosted
Comment on lines +18 to +19
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow runs on pull_request, so switching build-and-test to a self-hosted runner will execute untrusted PR code on your own runner machine. Consider using GitHub-hosted runners for PRs (or gating self-hosted runs to trusted events/branches only) to avoid runner compromise and secret exfiltration risks.

Suggested change
#runs-on: ubuntu-latest
runs-on: self-hosted
runs-on: ${{ github.event_name == 'pull_request' && 'ubuntu-latest' || 'self-hosted' }}

Copilot uses AI. Check for mistakes.
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -85,7 +86,8 @@ jobs:

build-release-binaries:
name: Build Release Binaries (Linux x86_64)
runs-on: ubuntu-latest
#runs-on: ubuntu-latest
runs-on: self-hosted
Comment on lines +89 to +90
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runs-on: self-hosted is very broad; these steps assume a Linux/Ubuntu-like environment (bash conditionals, apt-get, strip). Use runner labels (e.g., runs-on: [self-hosted, linux, x64] and/or a custom label for your prepared image) so the job can’t land on an incompatible self-hosted runner.

Copilot uses AI. Check for mistakes.
needs: build-and-test
if: github.ref == 'refs/heads/production' || github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/tags/')
strategy:
Expand Down Expand Up @@ -172,7 +174,8 @@ jobs:

docker-build:
name: Docker Build & Push (branches/tags)
runs-on: ubuntu-latest
#runs-on: ubuntu-latest
runs-on: self-hosted
Comment on lines +177 to +178
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title indicates all jobs should move off ubuntu-latest, but create-release still uses ubuntu-latest in this workflow. Either update the title/scope to reflect the partial migration, or move create-release to the intended runner type as well (keeping in mind any permissions/security requirements).

Copilot uses AI. Check for mistakes.
needs: build-and-test
if: |
github.ref == 'refs/heads/production' ||
Expand Down
Loading