Make the open and read_dir APIs safe by using pin#111
Draft
sosthene-nitrokey wants to merge 8 commits intomainfrom
Draft
Make the open and read_dir APIs safe by using pin#111sosthene-nitrokey wants to merge 8 commits intomainfrom
open and read_dir APIs safe by using pin#111sosthene-nitrokey wants to merge 8 commits intomainfrom
Conversation
This will also allow for more flexible `Storage` implementations that use `Vec<u8>` as a cache buffer and are not fixed to a single block size
The previous `RefCell` was only dealing with a pointer and the data was always held by the lfs side so the checking from the refcell was useless anyways This also contains a breaking change because the `unsafe` `open` function did not take the correct lifetime. It think it's an acceptable breaking change because the previous behaviour was buggy and any code that depends on it likely has a use after free.
`Filesystem` is still `!Sync`, so this allows putting the filesystem behind a `Mutex` and sharing it across threads but still prevents concurrent operations from multiple threads. See #108 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built on top of #110 and #101