Fix sip disallow

manifests/config.pp

@@ -167,6 +167,16 @@
       order   => '5',
     }
 
+    # Voicemail configuration
+    concat {"${astetcdir}/voicemail.conf":
+      notify => Exec['asterisk-voicemail-reload'],
+    }
+    concat::fragment { 'voicemail_general':
+      target  => "${astetcdir}/voicemail.conf",
+      content => template('asterisk/voicemail.conf.erb'),
+      order   => '10',
+    }
+
     # TODO /etc/init.d/asterisk
     # TODO /etc/logrotate.d/asterisk
   }
@@ -182,4 +192,10 @@
     command     => "${astbinary} -rx 'reload chan_iax2.so'",
     refreshonly => true,
   }
+
+  # Ask Asterisk to reload the voicemail configuration
+  exec { 'asterisk-voicemail-reload':
+    command     => "${astbinary} -rx 'voicemail reload'",
+    refreshonly => true,
+  }
 }

manifests/config/voicemail.pp

@@ -0,0 +1,35 @@
+# == Defined Type: asterisk::config::voicemail
+#  Define voicemails for use with Asterisk using concat::fragment on
+#  the vaoicemail.conf file.
+#
+# === Parameters
+#  [*id*]
+#    String. Voicemail id
+#    REQUIRED. No Default.
+#
+#  [*target*]
+#    String. Path to voicemail.conf.
+#    REQUIRED. No Default.
+#
+# ==== String Parameters
+#  The remaining parameters are strings as described in the Asterisk
+#  manuals for voicemails.
+#
+define asterisk::config::voicemail (
+  $target,
+  $id = $title,
+  $password = '',
+  $username = '',
+  $mail = '',
+  $pager = '',
+  $options = '',
+)
+{
+  validate_string ($target, $id, $password)
+
+  concat::fragment{"voicemail_${id}":
+    target  => $target,
+    content => template('asterisk/voicemail.erb'),
+    order   => '50',
+  }
+}

templates/device.erb

@@ -3,6 +3,9 @@ type = <%= @type %>
 <% if @accountcode != "" -%>
 accountcode = <%= @accountcode %>
 <% end -%>
+<% Array(@disallow).each do |a| -%>
+disallow = <%= a %>
+<% end -%>
 <% Array(@allow).each do |a| -%>
 allow = <%= a %>
 <% end -%>
@@ -66,9 +69,6 @@ directmediadeny = <%= @directmediadeny %>
 <% if @directmediapermit != "" -%>
 directmediapermit = <%= @directmediapermit %>
 <% end -%>
-<% Array(@disallow).each do |a| -%>
-disallow = <%= a %>
-<% end -%>
 <% if @dtmfmode != "" -%>
 dtmfmode = <%= @dtmfmode %>
 <% end -%>