ci: add multi-platform build tests and system-test workflows by 0xbigapple · Pull Request #6574 · tronprotocol/java-tron

0xbigapple · 2026-03-10T06:17:08Z

Summary

This PR enhances the CI pipeline by introducing multi-platform build tests, Checkstyle and system tests workflows.

Changes

1. Multi-platform build tests

Add build tests across multiple platforms and architectures:

Ubuntu — x86_64 + JDK 8 and aarch64 + JDK 17
macOS — x86_64 + JDK 8 and aarch64 + JDK 17
Debian — Debian 11 build test using the eclipse-temurin:8-jdk base image.

2. Rocky Linux build test

Since CentOS 7 and CentOS 8 images are not supported in GitHub-hosted runners, as described in the
GitHub-hosted runners documentation, a Rocky Linux build test has been added as a compatible replacement for CentOS 8.

3. Checkstyle workflow

Add a workflow to perform Checkstyle code style checks.

4. System test workflow

Add a workflow to execute a subset of daily build test cases from https://github.com/tronprotocol/system-test.

The workflow performs the following steps:

Start a network with one node including two SRs
Test core APIs
Deploy smart contracts
Trigger smart contract execution

5. Upgrade CodeQL from v3 to v4

Sunny6889 · 2026-03-10T07:19:54Z

.github/workflows/pr-check.yml

  pull_request:
    branches: [ 'develop', 'release_**' ]
-    types: [ opened, edited, synchronize, reopened ]
+    types: [ opened, synchronize, reopened ]


Removing edited from the trigger types means pr-lint won't re-run when the PR title or description is modified after opening. A contributor could pass the lint check initially, then edit the title to a non-conventional format before merging.

If the goal is to avoid unnecessary build/test runs on description edits, consider keeping edited in the workflow trigger and adding if: github.event.action != 'edited' to the build/test jobs so they skip edit-triggered runs while pr-lint still re-validates on every edit.

Good suggestion, I will optimize it.

Sunny6889 · 2026-03-10T07:34:25Z

.github/workflows/pr-check.yml

+      - name: Prepare checkstyle config copy
+        run: |
+          set -euxo pipefail
+          cp -f config/checkstyle/checkStyle.xml config/checkstyle/checkStyleAll.xml || true


why here || true ？also the same question for other two places

Because this step begins with set -euxo pipelinefail, any command returning a non-zero status will immediately terminate the script. true ensures that the script will continue execution even if checkStyle.xml does not exist (cp fails). it can delete here.

./gradlew --stop || true It cannot be removed. If there is no running daemon, --stop will return a non-zero value, which needs to be considered to prevent step failure.

halibobo1205 · 2026-03-10T07:42:15Z

.github/workflows/system-test.yml

+
+on:
+  pull_request:
+    branches: [ 'develop', 'release_**' ]


Is there a reason the master branch isn’t considered?

Good suggestion, I will add it later.

halibobo1205 · 2026-03-10T08:10:13Z

.github/workflows/pr-check.yml

        run: ./gradlew :framework:checkstyleMain :framework:checkstyleTest :plugins:checkstyleMain

      - name: Upload Checkstyle reports
        if: failure()


checkstyle { toolVersion = "${versions.checkstyle}" configFile = file("config/checkstyle/checkStyleAll.xml") // no failure condition configured }

Since checkStyleAll.xml sets <property name="severity" value="warning"/>, all violations are reported as warnings. Gradle's Checkstyle plugin only fails the task on error-level violations, so the task always succeeds regardless of how many violations exist. The CI job is effectively a no-op — violations never block PR merges.

Two Fix Options

Option A: Change severity to error in checkStyleAll.xml

Violations are promoted to error level, causing the Gradle task to fail by default (ignoreFailures=false).

<property name="severity" value="error"/>

Option B: Add maxWarnings = 0 in Gradle

checkstyle { toolVersion = "${versions.checkstyle}" configFile = file("config/checkstyle/checkStyleAll.xml") maxWarnings = 0 }

If we fix it as suggested above, the behavior may differ from the previous implementation. But we can try.

…event is edited

halibobo1205 · 2026-03-10T08:25:38Z

framework/build.gradle

 checkstyle {
    toolVersion = "${versions.checkstyle}"
    configFile = file("config/checkstyle/checkStyleAll.xml")
+    maxWarnings = 0


plugins need this, too.

warku123 · 2026-03-10T09:04:03Z

.github/workflows/pr-check.yml

+            os-name: macos
+            arch: x86_64
+          - java: '17'
+            runner: macos-latest


Just a minor thought: since macos-latest is a floating alias that could shift to a newer version over time, would it make sense to pin it to macos-26 to stay consistent with macos-26-intel?

It looks like macos-26 is already generally available (actions/runner-images#13739).
If there's a specific reason for using macos-latest here, I'd love to learn more about it!

Is there available image for macos-26 aarch64 ? I will fix it as macos-26.

Yes, according to actions/runner-images#13739, macos-26 points to Apple Silicon (aarch64) by default.

Thanks for the quick fix!

waynercheung · 2026-03-10T16:26:21Z

.github/workflows/pr-check.yml

 name: PR Check

 on:
+  push:


This may be a bug： the pr-lint will crash on push events.

This workflow(line 15) triggers on both push (line 4-5) and pull_request (line 6-8).

The script accesses context.payload.pull_request.title, but on push events context.payload.pull_request is undefined, which throws a TypeError and marks this job as failure. Since downstream jobs (build, docker-build-*) depend on pr-lint via needs, they will all be skipped on push events.

Suggest splitting into two workflows:

pr-check.yml: triggered by pull_request only, includes pr-lint + checkstyle + builds.

post-merge.yml: triggered by push only, includes checkstyle + builds (no pr-lint).

This avoids the need for conditional if / always() workarounds on the needs chain.

Thanks for you issue. I fix it as this: skip pr-lint when push; When the PR lint job succeeds or is skipped, the jobs depending on it can still run.

…the jobs depending on it can still run.

waynercheung · 2026-03-11T04:13:26Z

.github/workflows/pr-check.yml

 jobs:
  pr-lint:
    name: PR Lint
+    if: github.event_name == 'pull_request'


The fix works: adding if: github.event_name == 'pull_request' to pr-lint and !failure() to downstream jobs correctly handles the push/PR scenarios.

One remaining issue: !failure() also returns true when jobs are cancelled. If a user manually cancels the workflow, build jobs will still start. Suggest adding !cancelled():
if: github.event.action != 'edited' && !failure() && !cancelled()

Users cannot manually cancel only the PR lint job. When the PR is updated, the running PR lint job will be canceled and all jobs will be triggered again.

Thanks for the clarification. You're right that the concurrency group handles the PR update case well — the entire old run is cancelled and a new one starts fresh.

The !cancelled() is more about the manual "Cancel workflow run" case from the Actions UI. In that scenario, !failure() alone would briefly allow pending jobs to start before GitHub cancels them again. The practical impact is minimal — at most a few seconds of wasted runner time.

Adding !cancelled() is a best practice for correctness, but I agree it's not a blocking issue. Feel free to address it or leave as-is.

Thanks for your feedback. There is no strong need to add !cancelled() now. If a similar scenario occurs during execution, we can add it later.

waynercheung · 2026-03-11T06:17:20Z

.github/workflows/pr-check.yml


-      - name: Upload test reports
-        if: failure()
+  docker-build-rockylinux:


I think you can add timeout-minutes: 60 as the system-test job.
Besides, build and docker-build-debian11 can also add timeout-minutes.

waynercheung · 2026-03-11T06:23:35Z

.github/workflows/system-test.yml

+          java-version: '8'
+          distribution: 'temurin'
+
+      - name: Clone system-test


Using raw git clone + git checkout has a few drawbacks:

The release_workflow branch is hardcoded — if it's deleted or renamed, CI breaks with no clear error.

No GitHub token auth — will fail if the repo ever becomes private.

No shallow clone optimization.

Suggest using actions/checkout instead:

- name: Clone system-test uses: actions/checkout@v4 with: repository: tronprotocol/system-test ref: release_workflow path: system-test

Optimize it.

waynercheung · 2026-03-11T06:30:30Z

.github/workflows/system-test.yml

+      - name: Run system tests
+        working-directory: system-test
+        run: |
+          cp solcDIR/solc-linux-0.8.6 solcDIR/solc


If the system-test repo updates the solc version or changes the directory structure, this cp will fail and may produce confusing downstream test errors.

Suggest adding an existence check:

if [ ! -f solcDIR/solc-linux-0.8.6 ]; then echo "ERROR: solc binary not found at solcDIR/solc-linux-0.8.6" exit 1 fi cp solcDIR/solc-linux-0.8.6 solcDIR/solc

waynercheung · 2026-03-11T06:50:12Z

.github/workflows/pr-check.yml

          path: |
            ~/.gradle/caches
            ~/.gradle/wrapper
          key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle', '**/gradle-wrapper.properties') }}


Cache key glob patterns are inconsistent — checkstyle and build(line 174) use **/*.gradle, while rockylinux(line 213) and debian11(line 274) use **/*.gradle*. Both work the same for this project, but suggest standardizing to one pattern for maintainability.

It doesn't matter much. If needed, I will change it next time.

waynercheung · 2026-03-11T06:52:40Z

.github/workflows/pr-check.yml

  checkstyle:
    name: Checkstyle
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-24.04-arm


Checkstyle is pure static analysis and architecture-independent.
Why do you use ARM instead of ubuntu-latest (x86)?

Use a pinned version instead of a mutable version.

waynercheung · 2026-03-11T07:00:36Z

.github/workflows/pr-check.yml

-      - name: Build
-        run: ./gradlew clean build -x test
-
  checkstyle:


Nit (non-blocking): Currently checkstyle is only enabled for framework and plugins. It might be worth considering extending it to other modules (actuator, chainbase, common, etc.) in a follow-up PR to enforce consistent code style across the whole project.

Good idea. The current purpose is to migrate it from buildkite to workflow. Might extends it in another PR.

waynercheung

LGTM

jiangyuanshu added 2 commits March 10, 2026 11:51

init workflow

2be8685

init workflow

e560afe

Sunny6889 reviewed Mar 10, 2026

View reviewed changes

halibobo1205 reviewed Mar 10, 2026

View reviewed changes

jiangyuanshu added 2 commits March 10, 2026 16:11

add timeout for system-test; add master for push; trigger PR lint if …

7eacfea

…event is edited

add maxWarnings = 0 for checkstyle job

c5ec11c

halibobo1205 reviewed Mar 10, 2026

View reviewed changes

restore Autobuild for codeql; add maxWarnings for plugin gradle

1b2d1d8

warku123 reviewed Mar 10, 2026

View reviewed changes

jiangyuanshu added 2 commits March 10, 2026 17:14

remove checkstyle copy

63c17a4

fix the image runner macos-26

800d827

liuyifei001 approved these changes Mar 10, 2026

View reviewed changes

remove test code

fb43e54

halibobo1205 approved these changes Mar 10, 2026

View reviewed changes

waynercheung reviewed Mar 10, 2026

View reviewed changes

Sunny6889 approved these changes Mar 11, 2026

View reviewed changes

skip pr-lint when push; When the PR lint job succeeds or is skipped, …

ccca67c

…the jobs depending on it can still run.

waynercheung reviewed Mar 11, 2026

View reviewed changes

optimize checkout

e426142

waynercheung reviewed Mar 11, 2026

View reviewed changes

waynercheung approved these changes Mar 11, 2026

View reviewed changes

kuny0707 approved these changes Mar 11, 2026

View reviewed changes

kuny0707 merged commit 3fc3b53 into tronprotocol:develop Mar 11, 2026
14 checks passed

Conversation

0xbigapple commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

1. Multi-platform build tests

2. Rocky Linux build test

3. Checkstyle workflow

4. System test workflow

5. Upgrade CodeQL from v3 to v4

Uh oh!

Sunny6889 Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liuyifei001 Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Two Fix Options

Option A: Change severity to error in checkStyleAll.xml

Option B: Add maxWarnings = 0 in Gradle

Uh oh!

liuyifei001 Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liuyifei001 Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

waynercheung Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

waynercheung Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xbigapple commented Mar 10, 2026 •

edited

Loading

Sunny6889 Mar 10, 2026 •

edited

Loading

liuyifei001 Mar 10, 2026 •

edited

Loading

liuyifei001 Mar 10, 2026 •

edited

Loading

liuyifei001 Mar 10, 2026 •

edited

Loading

waynercheung Mar 10, 2026 •

edited

Loading

waynercheung Mar 11, 2026 •

edited

Loading

liuyifei001 Mar 11, 2026 •

edited

Loading