Log emulated access key instead of secret key#196
Merged
mosiac1 merged 1 commit intotrinodb:mainfrom May 28, 2025
Merged
Conversation
pranavr12
approved these changes
May 14, 2025
Randgalt
approved these changes
May 22, 2025
Unsure if this was instead for the initial development phases but we shouldn't be logging this now
mosiac1
force-pushed
the
feat/dont-log-secret
branch
from
8d67686 to
d84be47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unsure if this was instead for the initial development phases but we
shouldn't be logging this now