Merged
Conversation
Collaborator
Author
|
I also removed some comments from the tests that seemed a bit redundant. The comment above these tests saying that they were inspired by the Go tests seems sufficient. |
byroot
reviewed
Apr 1, 2026
Comment on lines
+507
to
+514
| assert_kind_of Time, time | ||
| assert_equal 2020, time.year | ||
| assert_equal 5, time.month | ||
| assert_equal 25, time.day | ||
| assert_equal 23, time.hour | ||
| assert_equal 22, time.min | ||
| assert_equal 1, time.sec | ||
| assert_equal 159491, time.usec |
Collaborator
There was a problem hiding this comment.
Suggested change
| assert_kind_of Time, time | |
| assert_equal 2020, time.year | |
| assert_equal 5, time.month | |
| assert_equal 25, time.day | |
| assert_equal 23, time.hour | |
| assert_equal 22, time.min | |
| assert_equal 1, time.sec | |
| assert_equal 159491, time.usec | |
| assert_kind_of Time, time | |
| assert_equal "2020-05-25 23:22:01.159491", time.iso8601(6) |
Might be simpler and clearer? Also is probably better to ensure we haven't confused usec with msec
byroot
approved these changes
Apr 1, 2026
composerinteralia
force-pushed
the
fix-nanosecond-bug
branch
2 times, most recently
from
d37aa61 to
bf44233
Compare
#286 accidentally added an unnecessary `/ 1000`, which made usec say `159` instead of `159491`
composerinteralia
force-pushed
the
fix-nanosecond-bug
branch
from
bf44233 to
ffe66de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#286 accidentally added an unnecessary
/ 1000, which made usec say159instead of159491