Fix native extension build with GCC 15#231
Merged
composerinteralia merged 3 commits intotrilogy-libraries:mainfrom Aug 4, 2025
Merged
Fix native extension build with GCC 15#231composerinteralia merged 3 commits intotrilogy-libraries:mainfrom
composerinteralia merged 3 commits intotrilogy-libraries:mainfrom
Conversation
|
Any chance this will get merged in the coming weeks? Many thanks. |
Contributor
Author
|
Duplicate of #229 |
Contributor
Author
|
I cannot reopen the older PR because it is not mine so I'm tracking this here. I still think we should merge this for two reasons:
|
Co-authored-by: Daniel Colson <danieljamescolson@gmail.com>
composerinteralia
approved these changes
Aug 4, 2025
Collaborator
composerinteralia
left a comment
There was a problem hiding this comment.
Using append_cflags makes sense to me and matches what the docs recommend: https://docs.ruby-lang.org/en/master/extension_rdoc.html#label-Prepare+extconf.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OS: Fedora 42
Ruby: 3.2.1
GCC: 15.1.1
The native extension build is broken with GCC 15 resulting in the same errors as described here: https://bugs.ruby-lang.org/issues/21290
CFLAGS should be appended with
append_cflagsinstead of directly appending them which fixes the problem.