[pull] main from MaterializeInc:main#824
Merged
pull[bot] merged 18 commits intotransparencies:mainfrom Mar 20, 2026
Merged
Conversation
Remove these sections if your commit already has a good description! ### Motivation console needs to be built from this repo now, it's no longer external ### Verification works for me locally
Clamp the tick interval of `probe::Ticker` to 1ms, to avoid a potential division by zero in `round_to_interval`.
`X509::from_pem` only reads the first certificate from a PEM bundle, so if `ssl_root_cert` contains multiple CA certificates (e.g., root + intermediates or multiple roots), only the first is loaded into the trust store. This causes TLS verification to fail with "unknown ca" when the relevant trust anchor is not the first cert in the bundle, diverging from libpq behavior which accepts CA bundles. Fix by using `X509::stack_from_pem` (which parses all certs) and adding each to the cert store, mirroring the pattern already used in `pkcs12der_from_pem` in the same file. Bug introduced in PR #13552 which changed from file-based `set_ca_file()` to in-memory `add_cert(X509::from_pem())`. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
When dropping a continual task, the CT's name was not recorded in dropped_item_names. This caused a panic in apply_catalog_implications_inner when an active subscribe or pending peek depended on the dropped CT, because the code tried to look up the name to include in the error message. Fix by inserting the CT's full_name into dropped_item_names, matching the pattern used by all other drop handlers (tables, sources, MVs, sinks, indexes). Spotted by Cursor Bugbot: #29673 (comment) Co-authored-by: Junie <junie@jetbrains.com>
I have a bunch of throwaway Python script that I don't want to check in or lint.
…5556) ### Motivation fixes MaterializeInc/database-issues#11255 ### Description Fixes a previous mistake in writing an assert - the assert was written as though it panics when the condition is true, so this inverts the condition, and improves variable names and error message to better clarify the intent.
For included items with PR links see: https://github.com/MaterializeInc/docs-automation/blob/main/release-notes/output/release_notes_v26.16.0.md For omitted items with PR links see: https://github.com/MaterializeInc/docs-automation/blob/main/release-notes/output/release_notes_v26.16.0_omitted.md **Borderline PRs omitted: 12** — [review borderline calls](https://github.com/MaterializeInc/docs-automation/blob/main/release-notes/output/release_notes_v26.16.0_omitted.md#borderline) --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Pranshu Maheshwari <maheshwarip@users.noreply.github.com> Co-authored-by: Pranshu Maheshwari <pranshu.maheshwari@materialize.com>
A "seqno lease" is the tool Persist uses internally to prevent garbage collection of a batch that a reader is still processing. It's important that we obtain the lease _before_ we choose the batch to return, to avoid a race where the state changes between the batch being selected and the lease being taken. Unfortunately, callers did this in the wrong order - chose a batch and then obtained a lease for it. This may have been exacerbated by the recent-ish #34590, which allows more aggressive seqno downgrades to avoid leaks. ### Motivation Incident response - a race here could cause an unexpected read-time halt.
Seen flaking in https://buildkite.com/materialize/nightly/builds/15716#019d0349-8a59-462b-a110-82c1ccaed455 Test run: https://buildkite.com/materialize/nightly/builds/15721 I'm in parallel trying to get a good reproducer to figure out the source of all this flakiness in Materialize/CI.
Running into rate limits, search api is very constrained at 30 requests/minute Test run shows that the search still works: https://buildkite.com/materialize/test/builds/118540
…t from newer version (#35544) See https://materializeinc.slack.com/archives/C01LKF361MZ/p1773859218988059 for context Test run: https://buildkite.com/materialize/nightly/builds/15712 This PR is intentionally on a 1 week old state to check.
### Motivation potential fix for MaterializeInc/database-issues#11225 - it at least clears up the 404 errors, not entirely clear if those were actually the cause of the slowdown, but even if not it'll make it easier to dig further if necessary ### Description we were unconditionally setting up watchers for Certificate resources on our custom resource controllers since those controllers can sometimes create Certificate resources, but if we are running in an environment which doesn't use certificates, cert-manager might not be installed at all, causing an error when we try to set up a watcher for its resources. ### Verification ran `bin/mzcompose --find orchestratord run documentation-defaults` locally with this change and it appeared to work correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )