Open
Conversation
antazoey
approved these changes
Mar 30, 2026
Collaborator
antazoey
left a comment
antazoey
left a comment
There was a problem hiding this comment.
Looks good but please remove the .DS_Store file and maybe add that to gitignore before merge.
Also one suggestion on using an Enum type instead of a str literal
| The shared fields for all inner settlement requests. | ||
| """ | ||
|
|
||
| mode: Literal["margin", "spot"] = "margin" |
Collaborator
There was a problem hiding this comment.
It may be better to use an Enum
heytdep
force-pushed
the
feat/settlement-mode
branch
from
e1f16d4 to
59d6a45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.