Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const loading = isLoading || isLoadingAiReviewConfig || isLoadingAiReviewDecisions | ||
|
|
||
| const { isAdmin }: UseRolePermissionsResult = useRolePermissions() | ||
| const rolePermissions: UseRolePermissionsResult = useRolePermissions() |
There was a problem hiding this comment.
[💡 maintainability]
The variable rolePermissions is assigned but only used to destructure isAdmin and hasSubmitterRole. Consider destructuring directly from useRolePermissions() to avoid unnecessary variable assignment.
| + 'Improve your submission and resubmit.' | ||
| }, [currentDecision?.submissionLocked, failedGatingReviewers]) | ||
| // Message text varies by role | ||
| const roleBasedText = hasSubmitterRole |
There was a problem hiding this comment.
[💡 readability]
The roleBasedText variable contains a multiline string. Consider using template literals with consistent indentation for better readability.
| // Message text varies by role | ||
| const roleBasedText = hasSubmitterRole | ||
| ? `This submission is automatically failed regardless of Overall Score. | ||
| Improve your submission and resubmit.` |
There was a problem hiding this comment.
[💡 readability]
The string concatenation in roleBasedText could be simplified by using template literals for better readability.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
2 participants
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-4314
What's in this PR?
Fixes text based on roles