Skip to content

Improve Perfetto tracing configuration and trace pull timeout #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tobrun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve Perfetto tracing configuration and trace pull timeout #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .claude/skills/start-recording.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ Replace `<pkg>` with the package name from the `am start` component (the part be
If `--trace` was used, after launching the app (and after the gfxinfo reset if `--perf` was also used), start the Perfetto trace in the background:

```bash
./android-qa shell perfetto -o /data/misc/perfetto-traces/trace.perfetto-trace -t 300s -d gfx view input am wm dalvik sched freq
./android-qa shell perfetto -o /data/misc/perfetto-traces/trace.perfetto-trace --no-guardrails -d gfx view input am wm dalvik sched freq
```

The `-d` flag detaches immediately. The command is recorded in the session. The trace runs until `./stop-recording` stops it cleanly.
The `-d` flag detaches immediately and `--no-guardrails` disables duration and size limits so the trace runs for the entire test session. The command is recorded in the session. The trace runs until `./stop-recording` stops it cleanly via SIGTERM.
2 changes: 1 addition & 1 deletion stop-recording
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ def capture_perfetto_trace(lock_data, session_dir):
try:
result = subprocess.run(
adb_base + ["pull", PERFETTO_TRACE_DEVICE_PATH, local_trace_path],
capture_output=True, text=True, timeout=30,
capture_output=True, text=True, timeout=120,
)
if result.returncode != 0:
print("Warning: failed to pull Perfetto trace: %s" % result.stderr.strip(), file=sys.stderr)
Expand Down