Fix i64.atomic.rmw.or using AND instead of OR#564
Open
sumleo wants to merge 1 commit intotitzer:masterfrom
Open
Fix i64.atomic.rmw.or using AND instead of OR#564sumleo wants to merge 1 commit intotitzer:masterfrom
sumleo wants to merge 1 commit intotitzer:masterfrom
Conversation
The I64_ATOMIC_RMW_OR handler incorrectly dispatched to V3Eval.I64_AND instead of V3Eval.I64_OR, causing the atomic read-modify-write to perform a bitwise AND instead of the intended bitwise OR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I64_ATOMIC_RMW_ORcase in V3Interpreter dispatchesV3Eval.I64_ANDinstead ofV3Eval.I64_OR, causingi64.atomic.rmw.orto perform a bitwise AND instead of OR.Details
V3Interpreter.v3:527— simple typo:I64_AND→I64_OR.